rdblue commented on a change in pull request #4177:
URL: https://github.com/apache/iceberg/pull/4177#discussion_r812198410
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java
##########
@@ -350,11 +354,19 @@ public void endInput() throws IOException {
return
SimpleVersionedSerialization.writeVersionAndSerialize(DeltaManifestsSerializer.INSTANCE,
deltaManifests);
}
+ @Override
+ public void open() throws Exception {
+ this.workerPool =
ThreadPools.newWorkerPool("iceberg-files-committer-worker-pool-%d");
+ }
+
@Override
public void close() throws Exception {
if (tableLoader != null) {
tableLoader.close();
}
+ if (workerPool != null) {
Review comment:
Nit: we add a newline after control flow blocks and the following
statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
