yittg commented on a change in pull request #4177:
URL: https://github.com/apache/iceberg/pull/4177#discussion_r812575439
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java
##########
@@ -129,6 +135,10 @@ public void initializeState(StateInitializationContext
context) throws Exception
Preconditions.checkArgument(maxContinuousEmptyCommits > 0,
MAX_CONTINUOUS_EMPTY_COMMITS + " must be positive");
+ int manifestsScanParallelism = PropertyUtil.propertyAsInt(
+ table.properties(), MANIFESTS_SCAN_PARALLELISM,
ThreadPools.WORKER_THREAD_POOL_SIZE);
+ this.workerPool =
ThreadPools.newWorkerPool("iceberg-files-committer-worker-pool",
manifestsScanParallelism);
Review comment:
configured from `table#properties` like the
`MAX_CONTINUOUS_EMPTY_COMMITS` configuration to make it simple for now. Add
another ways if it's needed in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
