yittg commented on a change in pull request #4177:
URL: https://github.com/apache/iceberg/pull/4177#discussion_r812574121
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/StreamingMonitorFunction.java
##########
@@ -79,6 +83,11 @@ public StreamingMonitorFunction(TableLoader tableLoader,
ScanContext scanContext
this.scanContext = scanContext;
}
+ @Override
+ public void open(Configuration parameters) throws Exception {
Review comment:
> Should the pool size be configured by parameters?
Configured from scan context;
> Also, is there a way to share pools if there are multiple Iceberg
operators in the same Flink job?
I think it's hard to share, and it will easily get meaningless across
distributed nodes.
What do you think, @rdblue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
