stevenzwu commented on a change in pull request #4177:
URL: https://github.com/apache/iceberg/pull/4177#discussion_r824155355
##########
File path:
flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/source/SplitHelpers.java
##########
@@ -72,7 +73,8 @@ private SplitHelpers() {
}
final ScanContext scanContext = ScanContext.builder().build();
- final List<IcebergSourceSplit> splits =
FlinkSplitPlanner.planIcebergSourceSplits(table, scanContext);
+ final List<IcebergSourceSplit> splits =
FlinkSplitPlanner.planIcebergSourceSplits(
+ table, scanContext, ThreadPools.getWorkerPool());
Review comment:
this uses the default/shared worker pool, while others use a separate
pool. what are the reasons?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
