samredai commented on a change in pull request #4262:
URL: https://github.com/apache/iceberg/pull/4262#discussion_r820108615
##########
File path: python/pyproject.toml
##########
@@ -18,6 +18,10 @@
[build-system]
requires = [
"setuptools>=42",
- "wheel"
+ "wheel",
Review comment:
I looked a bit closer at what mypy is doing and it's getting confused
because you've given actual names to the registered functions. The convention
is to only name the generic function and use then use `_` for the additional
type based functions that you're registering (like the example in the
[docs](https://docs.python.org/3/library/functools.html#functools.singledispatchmethod)).
I confirmed that will pass all mypy inspection.
##########
File path: python/pyproject.toml
##########
@@ -18,6 +18,10 @@
[build-system]
requires = [
"setuptools>=42",
- "wheel"
+ "wheel",
Review comment:
I looked a bit closer at what mypy is doing and it's getting confused
because you've given actual names to the registered functions. The convention
is to only name the generic function and then use `_` for the additional type
based functions that you're registering (like the example in the
[docs](https://docs.python.org/3/library/functools.html#functools.singledispatchmethod)).
I confirmed that will pass all mypy inspection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
