dramaticlly commented on a change in pull request #4262:
URL: https://github.com/apache/iceberg/pull/4262#discussion_r820936944
##########
File path: python/pyproject.toml
##########
@@ -18,6 +18,10 @@
[build-system]
requires = [
"setuptools>=42",
- "wheel"
+ "wheel",
Review comment:
> The convention is to only name the generic function and then use _ for
the additional type based functions that you're registering to that generic
function (like the example in the
[docs](https://docs.python.org/3/library/functools.html#functools.singledispatchmethod)).
Got it, originally I was afraid of this underscore might be confusion
because we need to use it more than once in the same class but I guess it's
actually get myself into more trouble than intended. Thank you for the
clarification and help, I am now able to comply with convention and remove all
unnecessary comments about mypy ignore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
