openinx commented on a change in pull request #3991:
URL: https://github.com/apache/iceberg/pull/3991#discussion_r821459191
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java
##########
@@ -469,11 +469,9 @@ private static void validateFlinkTable(CatalogBaseTable
table) {
Preconditions.checkArgument(table instanceof CatalogTable, "The Table
should be a CatalogTable.");
TableSchema schema = table.getSchema();
- schema.getTableColumns().forEach(column -> {
- if (!FlinkCompatibilityUtil.isPhysicalColumn(column)) {
- throw new UnsupportedOperationException("Creating table with computed
columns is not supported yet.");
- }
- });
+ if (!FlinkCompatibilityUtil.containsPhysicalColumnsOnly(schema)) {
Review comment:
How about naming it as `allPhysicalColumns` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
