openinx commented on a change in pull request #3991:
URL: https://github.com/apache/iceberg/pull/3991#discussion_r821460096
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/util/FlinkCompatibilityUtil.java
##########
@@ -39,7 +41,9 @@ private FlinkCompatibilityUtil() {
return InternalTypeInfo.of(rowType);
}
- public static boolean isPhysicalColumn(TableColumn column) {
- return column.isPhysical();
+ /** Returns true if there are only physical columns in the given {@link
TableSchema}. */
Review comment:
Nit: Please format the Javadoc like :
```
/**
* Returns true if there are only physical columns in the given {@link
TableSchema}.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
