openinx commented on a change in pull request #3991:
URL: https://github.com/apache/iceberg/pull/3991#discussion_r821476799
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/RowDataFileScanTaskReader.java
##########
@@ -83,6 +95,12 @@ public RowDataFileScanTaskReader(Schema tableSchema, Schema
projectedSchema,
iterable = CloseableIterable.transform(iterable,
rowDataProjection::wrap);
}
+ if (projectedFields != null) {
+ RowDataNestProjection rowDataProjection =
RowDataNestProjection.create(tableSchema, projectedSchema,
+ projectedFields);
+ iterable = CloseableIterable.transform(iterable,
rowDataProjection::wrap);
+ }
Review comment:
Why do we need to project the iterable<RowData> twice ( we have already
projected the fields in line95, so why need this extra projection...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
