openinx commented on a change in pull request #4291:
URL: https://github.com/apache/iceberg/pull/4291#discussion_r823294017
##########
File path: orc/src/main/java/org/apache/iceberg/orc/ORC.java
##########
@@ -191,28 +198,26 @@ private Context(long stripeSize, long blockSize) {
this.blockSize = blockSize;
}
- static Context dataContext(Configuration conf) {
- long stripeSize = TableProperties.ORC_STRIPE_SIZE_BYTES_DEFAULT;
- stripeSize = conf.getLong(OrcConf.STRIPE_SIZE.getAttribute(),
stripeSize);
- stripeSize = conf.getLong(OrcConf.STRIPE_SIZE.getHiveConfName(),
stripeSize);
- stripeSize = conf.getLong(TableProperties.ORC_STRIPE_SIZE_BYTES,
stripeSize);
+ static Context dataContext(Map<String, String> conf) {
Review comment:
Could we always use `config` to indicate that we are referring a
configure `Map<String, String>` ? The `conf` looks like a hadoop configuration
in my mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
