openinx commented on a change in pull request #4291:
URL: https://github.com/apache/iceberg/pull/4291#discussion_r823392512
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -143,6 +143,10 @@ private TableProperties() {
public static final String DELETE_ORC_BLOCK_SIZE_BYTES =
"write.delete.orc.block-size-bytes";
public static final long ORC_BLOCK_SIZE_BYTES_DEFAULT = 256L * 1024 * 1024;
// 256 MB
+ public static final String ORC_VECTOR_ROW_BATCH_SIZE =
"write.orc.vectorized-row-batch-size";
Review comment:
We are replacing the old `iceberg.orc.vectorbatch.size` with the newly
introduced `writer.orc.vectorized-row-batch-size` here , right ? In this way,
the old table using the old config key won't take any effect in the next
release. I think we'd better to keep the original approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
