openinx commented on a change in pull request #4291:
URL: https://github.com/apache/iceberg/pull/4291#discussion_r823297752



##########
File path: 
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/data/TestSparkOrcReadMetadataColumns.java
##########
@@ -123,7 +124,7 @@ public void writeFile() throws IOException {
         // write in such a way that the file contains 10 stripes each with 100 
rows
         .set("iceberg.orc.vectorbatch.size", "100")
         .set(OrcConf.ROWS_BETWEEN_CHECKS.getAttribute(), "100")
-        .set(OrcConf.STRIPE_SIZE.getAttribute(), "1")

Review comment:
       So looks like the default value of table property 
`write.orc.stripe-size-bytes` will override the set value from original ORC 
config key (`orc.stripe.size` ) ? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to