hililiwei commented on a change in pull request #4291:
URL: https://github.com/apache/iceberg/pull/4291#discussion_r823424545
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -143,6 +143,10 @@ private TableProperties() {
public static final String DELETE_ORC_BLOCK_SIZE_BYTES =
"write.delete.orc.block-size-bytes";
public static final long ORC_BLOCK_SIZE_BYTES_DEFAULT = 256L * 1024 * 1024;
// 256 MB
+ public static final String ORC_VECTOR_ROW_BATCH_SIZE =
"write.orc.vectorized-row-batch-size";
Review comment:
`iceberg.orc.vectorbatch.size` doesn't fit our naming conventions.
Previously, it was a private variable and was not exposed as a public table
configuration. In my humble opinion, if we formally expose it as a table
configuration,
, would it be better to use a standard name?
> Config naming
> 1.Use - to link words in one concept
> For example, preferred convection access-key-id rather than
access.key.id
> 2.Use . to create a hierarchy of config groups
> For example, s3 in s3.access-key-id, s3.secret-access-key
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
