singhpk234 commented on a change in pull request #4259:
URL: https://github.com/apache/iceberg/pull/4259#discussion_r820853651
##########
File path: aws/src/test/java/org/apache/iceberg/aws/s3/TestS3OutputStream.java
##########
@@ -85,6 +87,8 @@
private final Random random = new Random(1);
private final Path tmpDir = Files.createTempDirectory("s3fileio-test-");
private final String newTmpDirectory = "/tmp/newStagingDirectory";
+ private final List<Tag> tags = ImmutableList.of(
+ Tag.builder().key("abc").value("123").build());
Review comment:
[question] what would be the behaviour when
```
private final List<Tag> tags = ImmutableList.of(
Tag.builder().key("abc").value("123").build(),
Tag.builder().key("abc").value("xyz").build());
```
- does for tag abc we will have xyz as value or 123 or the request will be
rejected ?
- Do we require to maintain uniqueness at Tag Key level if yes then
List<Tag> might not be a good DS.
Are these scenarios handled via :
```java
if (!tags.isEmpty()) {
requestBuilder.tagging(Tagging.builder().tagSet(tags).build());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
