rajarshisarkar commented on a change in pull request #4259:
URL: https://github.com/apache/iceberg/pull/4259#discussion_r823570975
##########
File path: aws/src/test/java/org/apache/iceberg/aws/s3/TestS3OutputStream.java
##########
@@ -85,6 +87,8 @@
private final Random random = new Random(1);
private final Path tmpDir = Files.createTempDirectory("s3fileio-test-");
private final String newTmpDirectory = "/tmp/newStagingDirectory";
+ private final List<Tag> tags = ImmutableList.of(
+ Tag.builder().key("abc").value("123").build());
Review comment:
Request will be rejected in case we have duplicate keys:
https://docs.aws.amazon.com/awsaccountbilling/latest/aboutv2/allocation-tag-restrictions.html
Though, we are not supposed to have duplicate keys as the catalog
`properties` map maintains uniqueness. So, if the user passes:
```
--conf spark.sql.catalog.my_catalog.s3.write.tags.my_key=my_val \
--conf spark.sql.catalog.my_catalog.s3.write.tags.my_key=my_val2
```
then the `properties` map would store only `s3.write.tags.my_key=my_val2`
which is later parsed to extract `my_key=my_val2` and then converted to
`writeTags`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
