rdblue commented on a change in pull request #4177:
URL: https://github.com/apache/iceberg/pull/4177#discussion_r824171849
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/StreamingMonitorFunction.java
##########
@@ -79,6 +83,16 @@ public StreamingMonitorFunction(TableLoader tableLoader,
ScanContext scanContext
this.scanContext = scanContext;
}
+ @Override
+ public void open(Configuration parameters) throws Exception {
+ super.open(parameters);
+
+ final String jobId = getRuntimeContext().getJobId().toString();
+ this.workerPool = ThreadPools.newKeyedWorkerPool(jobId,
"flink-worker-pool", scanContext.planParallelism());
Review comment:
I agree here. Since this is creating a different thread pool per job ID,
the thread name prefix should also include the job ID to get unique names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
