jackye1995 commented on a change in pull request #4334:
URL: https://github.com/apache/iceberg/pull/4334#discussion_r828413175
##########
File path: aws/src/integration/java/org/apache/iceberg/aws/AwsIntegTestUtil.java
##########
@@ -47,6 +58,23 @@ public static String testBucketName() {
return System.getenv("AWS_TEST_BUCKET");
}
+ /**
+ * Get the environment variable AWS_TEST_ACCESS_POINT for a default bucket
to use for testing
+ * @return bucket name
+ */
+ public static String testAccessPointName() {
+ return System.getenv("AWS_TEST_ACCESS_POINT");
+ }
+
+ /**
+ * Get AccessPointARN for a default bucket to use for testing
+ * @return access point arn
+ */
+ public static String testAccessPointARN() {
+ // format : arn:aws:s3:region:account-id:accesspoint/resource
+ return String.format("arn:aws:s3:%s:%s:accesspoint/%s", testRegion(),
testAccountId(), testAccessPointName());
Review comment:
partition is not always `aws`, should use `PartitionMetadata.of(region)`
to get the partition value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
