singhpk234 commented on a change in pull request #4334:
URL: https://github.com/apache/iceberg/pull/4334#discussion_r828799949
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java
##########
@@ -68,6 +68,7 @@
private MetricsContext metrics = MetricsContext.nullMetrics();
private final AtomicBoolean isResourceClosed = new AtomicBoolean(false);
private Set<Tag> writeTags = Sets.newHashSet();
+ private Map<String, String> bucketToAccessPointMapping = Maps.newHashMap();
Review comment:
I agree with this, but by naming it accessPoints at first glance could
mean just a collection of access points where as here what we actually have is
a mapping from s3 bucket to accessPoint, if this rational makes sense I would
like to keep it as its.. WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
