singhpk234 commented on a change in pull request #4334:
URL: https://github.com/apache/iceberg/pull/4334#discussion_r828760966
##########
File path:
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java
##########
@@ -78,17 +83,23 @@ public static void beforeClass() {
clientFactory = AwsClientFactories.defaultFactory();
s3 = clientFactory.s3();
kms = clientFactory.kms();
+ s3Control = clientFactory.s3Control();
bucketName = AwsIntegTestUtil.testBucketName();
+ accountId = AwsIntegTestUtil.testAccountId();
+ accessPointName = AwsIntegTestUtil.testAccessPointName();
prefix = UUID.randomUUID().toString();
contentBytes = new byte[1024 * 1024 * 10];
deletionBatchSize = 3;
content = new String(contentBytes, StandardCharsets.UTF_8);
kmsKeyArn = kms.createKey().keyMetadata().arn();
+
+ AwsIntegTestUtil.createAccessPoint(s3Control, accessPointName, bucketName,
accountId);
Review comment:
yes , we can and these arguments are indeed not required in the present
set-up can be directly accessed in the Util class itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
