rdblue commented on code in PR #4491:
URL: https://github.com/apache/iceberg/pull/4491#discussion_r842017157
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##########
@@ -235,20 +228,20 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge) {
@Override
public void renameTable(TableIdentifier from, TableIdentifier toOriginal) {
- reference.checkMutable();
+ client.getRef().checkMutable();
TableIdentifier to = NessieUtil.removeCatalogName(toOriginal, name());
- IcebergTable existingFromTable = table(from);
+ IcebergTable existingFromTable = client.table(from);
if (existingFromTable == null) {
- throw new NoSuchTableException("table %s doesn't exists", from.name());
+ throw new NoSuchTableException("table '%s' doesn't exists", from.name());
Review Comment:
As long as we're touching these, could we use the more standard exception
messages? This is usually `Table does not exist: %s`. That's nice because you
don't need quotes to see when it is empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
