rdblue commented on code in PR #4491:
URL: https://github.com/apache/iceberg/pull/4491#discussion_r842018310
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##########
@@ -290,32 +285,34 @@ public void renameTable(TableIdentifier from,
TableIdentifier toOriginal) {
@Override
public void createNamespace(Namespace namespace, Map<String, String>
metadata) {
try {
- reference.checkMutable();
- api.createNamespace()
- .reference(reference.getReference())
+ client.getRef().checkMutable();
+ client.getApi().createNamespace()
Review Comment:
It seems to me that the client should expose `createNamespace()` that does
the check above and exposes this API? It seems weird that this is basically
asking the client for its internal state and modifying that state (violates
"tell don't ask").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
