nastra commented on code in PR #4491:
URL: https://github.com/apache/iceberg/pull/4491#discussion_r842395832
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##########
@@ -290,32 +285,34 @@ public void renameTable(TableIdentifier from,
TableIdentifier toOriginal) {
@Override
public void createNamespace(Namespace namespace, Map<String, String>
metadata) {
try {
- reference.checkMutable();
- api.createNamespace()
- .reference(reference.getReference())
+ client.getRef().checkMutable();
+ client.getApi().createNamespace()
+ .reference(client.getRef().getReference())
.namespace(org.projectnessie.model.Namespace.of(namespace.levels()))
.create();
- refresh();
+ client.refresh();
} catch (NessieNamespaceAlreadyExistsException e) {
throw new AlreadyExistsException(e, "Namespace '%s' already exists.",
namespace);
} catch (NessieNotFoundException e) {
- throw new RuntimeException(String.format("Cannot create Namespace '%s':
ref is no longer valid.", namespace), e);
+ throw new RuntimeException(String.format("Cannot create Namespace '%s':
" +
+ "ref '%s' is no longer valid.", namespace,
client.getRef().getName()), e);
Review Comment:
yep, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
