nastra commented on code in PR #4491:
URL: https://github.com/apache/iceberg/pull/4491#discussion_r842395714
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##########
@@ -290,32 +285,34 @@ public void renameTable(TableIdentifier from,
TableIdentifier toOriginal) {
@Override
public void createNamespace(Namespace namespace, Map<String, String>
metadata) {
try {
- reference.checkMutable();
- api.createNamespace()
- .reference(reference.getReference())
+ client.getRef().checkMutable();
+ client.getApi().createNamespace()
Review Comment:
I agree. my initial approach was to just move a few things over to the
`NessieIcebergClient`, but now it makes perfect sense to have most of the code
in the client itself, which is then just used by the catalog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
