rdblue commented on code in PR #4495:
URL: https://github.com/apache/iceberg/pull/4495#discussion_r842964054
##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java:
##########
@@ -69,18 +75,42 @@
private Object conf = null;
private FileIO io = null;
+ public RESTCatalog() {
+ this(new HTTPClientFactory());
+ }
+
RESTCatalog(Function<Map<String, String>, RESTClient> clientBuilder) {
this.clientBuilder = clientBuilder;
}
@Override
public void initialize(String name, Map<String, String> props) {
+ Map<String, String> mergedProps = fetchAndMergeWithServerConf(props);
+ initializeInternal(name, mergedProps);
+ }
+
+ /**
+ * Performs the normal initialization steps after calling the config route
and merging the initial
+ * configuration with any configuration provided by the server.
+ * <p>
+ * See {@link RESTCatalogConfigResponse} for details on merging the initial
client and server configuration.
+ *
+ * @param name Name of this RESTCatalog
+ * @param props Properties to use, merged with any server-provided
configuration.
+ */
+ @VisibleForTesting
+ void initializeInternal(String name, Map<String, String> props) {
Review Comment:
I think we should remove this method. This appears to be used because the
`RESTCatalogAdaptor` doesn't currently implement the config route, right? But
if it returned the correct response then we would be able to use the regular
`initialize` method in tests and could avoid having this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
