rdblue commented on code in PR #4495:
URL: https://github.com/apache/iceberg/pull/4495#discussion_r842966704
##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java:
##########
@@ -69,18 +75,42 @@
private Object conf = null;
private FileIO io = null;
+ public RESTCatalog() {
+ this(new HTTPClientFactory());
+ }
+
RESTCatalog(Function<Map<String, String>, RESTClient> clientBuilder) {
this.clientBuilder = clientBuilder;
}
@Override
public void initialize(String name, Map<String, String> props) {
+ Map<String, String> mergedProps = fetchAndMergeWithServerConf(props);
+ initializeInternal(name, mergedProps);
+ }
+
+ /**
+ * Performs the normal initialization steps after calling the config route
and merging the initial
+ * configuration with any configuration provided by the server.
+ * <p>
+ * See {@link RESTCatalogConfigResponse} for details on merging the initial
client and server configuration.
+ *
+ * @param name Name of this RESTCatalog
+ * @param props Properties to use, merged with any server-provided
configuration.
+ */
+ @VisibleForTesting
+ void initializeInternal(String name, Map<String, String> props) {
this.client = clientBuilder.apply(props);
- this.catalogName = name;
this.properties = ImmutableMap.copyOf(props);
- this.paths = ResourcePaths.forCatalogProperties(props);
- String ioImpl = props.get(CatalogProperties.FILE_IO_IMPL);
- this.io = CatalogUtil.loadFileIO(ioImpl != null ? ioImpl :
ResolvingFileIO.class.getName(), props, conf);
+ this.catalogName = name;
+ this.paths = ResourcePaths.forCatalogProperties(properties);
+ String ioImpl = properties.get(CatalogProperties.FILE_IO_IMPL);
+ this.io = CatalogUtil.loadFileIO(ioImpl != null ? ioImpl :
ResolvingFileIO.class.getName(), properties, conf);
Review Comment:
It looks like these lines don't need to change at all. The current set of
changes is to reorder some of them (move catalogName assignment) and rename
`props` to `properties`. I think we can avoid making at least some of these
changes. But I would merge the methods together first, since that will affect
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
