rdblue commented on code in PR #4495:
URL: https://github.com/apache/iceberg/pull/4495#discussion_r842976150
##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java:
##########
@@ -405,4 +435,23 @@ private String fullTableName(TableIdentifier ident) {
return Pair.of(tableClient, tableIO);
}
+
+ private Map<String, String> fetchAndMergeWithServerConf(Map<String, String>
props) {
Review Comment:
I think this would be cleaner if it just fetched the config and returned the
response. That way it does one only thing. The only call that would be moved
outside is the `merge` call, which probably shouldn't be in the `try` block
anyway.
Then the caller would look like this:
```java
ConfigResponse config = fetchConfig(properties);
Map<String, String> props = config.merge(properties);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
