sumeetgajjar commented on PR #4942: URL: https://github.com/apache/iceberg/pull/4942#issuecomment-1145161981
Hi @pvary, thank you for your comments. > Is this exception in the logs is soo confusing, so this worth the complexity in the test code? In this case, the refactored test code does add additional checks but I believe those are justifiable given they reduce noise from the test logs. IMO, the less noise we generate during tests the better it is while triaging test failures. Especially spark tests where we also have tons of logs from the spark as well. > Coming from Hive background seeing this exception seems perfectly okay, but I have 6 years of indoctrination so I am not a representative example. Maybe, I believe it is subjective. I was recently triaging a couple of spark-iceberg test failures in our downstream iceberg branches and the test logs were full of the above exception stacktrace. The actual failures were shadowed by them and it took me a while to narrow down on the right stacktrace. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
