sumeetgajjar commented on PR #4942: URL: https://github.com/apache/iceberg/pull/4942#issuecomment-1145614512
Hi @pvary @kbendick, Thank you for the comments. > I also consider this to be a normal-ish log, along the lines of "illegal reflective access" and similar things. I agree that some exceptions (in this case `AlreadyExistsException` and as Kyle mentioned "illegal reflective access") can be considered normal after prolonged exposure to them and we grow oblivious to them. However, I still feel if we can avoid them in the first place, then we should. > I also have concerns about the additional usage of spark.sql (and the general complexity of that part). I've removed the use of `spark.sql` and simplified the namespace exists check logic to simply use `catalog.namespaceExists`. Please let me know how you feel about those. If it still feels complex, I can revert the changes in `SparkTestBaseWithCatalog` and simply keep the part in `SparkTestBase` that was deemed comfortable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
