pvary commented on code in PR #4942:
URL: https://github.com/apache/iceberg/pull/4942#discussion_r889606806
##########
spark/v2.4/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java:
##########
@@ -85,7 +85,10 @@ public static void startMetastoreAndSpark() {
CatalogUtil.loadCatalog(HiveCatalog.class.getName(), "hive",
ImmutableMap.of(), hiveConf);
try {
- catalog.createNamespace(Namespace.of("default"));
+ Namespace defaultNamespace = Namespace.of("default");
Review Comment:
This is test code. I would remove anything which is not strictly needed.
Also getting an AlreadyExistsException after checking for existence should
be a bug if there is no concurrency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
