kbendick commented on PR #4942:
URL: https://github.com/apache/iceberg/pull/4942#issuecomment-1145199927
> @sumeetgajjar: Could you please check the failures?
>
> I am comfortable with this:
>
> ```
> Namespace defaultNamespace = Namespace.of("default");
> if (!catalog.namespaceExists(defaultNamespace)) {
> catalog.createNamespace(defaultNamespace);
> }
> ```
>
> I am not entirely sure about these:
>
> ```
> boolean createNamespace = isHadoopCatalog || spark.sql("SHOW
NAMESPACES IN " + catalogName)
> .filter("namespace = 'default'")
> .isEmpty();
> if (createNamespace) {
> sql("CREATE NAMESPACE IF NOT EXISTS " + catalogName + ".default");
> }
> ```
Ditto. I also have concerns about the additional usage of `spark.sql` (and
the general complexity of that part). I also consider this to be a normal-ish
log, along the lines of "illegal reflective access" and similar things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
