chenjunjiedada commented on code in PR #5100:
URL: https://github.com/apache/iceberg/pull/5100#discussion_r906624770
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -148,6 +168,12 @@ private List<Predicate<T>> applyEqDeletes() {
Schema deleteSchema = TypeUtil.select(requiredSchema, ids);
+ if (filePath.endsWith(".parquet") && parquetReader != null) {
Review Comment:
I think we can change the ctor parameter from `String` to `DataFile` and
then here we can check file.format().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
