Zhangg7723 commented on code in PR #5100:
URL: https://github.com/apache/iceberg/pull/5100#discussion_r907983599
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -133,10 +144,19 @@ public CloseableIterable<T> filter(CloseableIterable<T>
records) {
private List<Predicate<T>> applyEqDeletes() {
List<Predicate<T>> isInDeleteSets = Lists.newArrayList();
+ Map<BlockMetaData, BloomFilterReader> parquetBloomFilterReader =
Maps.newHashMap();
+ ParquetFileReader parquetReader = null;
+ Predicate<Record> isInBloomFilter = null;
if (eqDeletes.isEmpty()) {
return isInDeleteSets;
}
+ // load bloomfilter readers from data file
+ if (filePath.endsWith(".parquet")) {
Review Comment:
You mean we check the bloom filter by table properties, right? but the bloom
filter properties may be updated, the bloom filter in current file is unmatched
with table properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
