Zhangg7723 commented on code in PR #5100:
URL: https://github.com/apache/iceberg/pull/5100#discussion_r907977433
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -148,6 +168,12 @@ private List<Predicate<T>> applyEqDeletes() {
Schema deleteSchema = TypeUtil.select(requiredSchema, ids);
+ if (filePath.endsWith(".parquet") && parquetReader != null) {
Review Comment:
the change for constructor parameters is only for Trino supporting mor，Trino
wrapped a dummy fileScanTask for data file currently, the author wants to
remove fileScanTask implemented in Trino, and use the filePath parameter. If we
change it to dataFile, compatibility is a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
