pvary commented on code in PR #5166:
URL: https://github.com/apache/iceberg/pull/5166#discussion_r911088095
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -547,6 +547,11 @@ protected Map<String, String> properties() {
return catalogProperties == null ? ImmutableMap.of() : catalogProperties;
}
+ public void close() {
+ fileIO.close();
+ clients.close();
Review Comment:
The current practice is that we use `CatalogUtil.loadCatalog` to create the
Catalog every time when we load a table. Opening and closing the clientPool
(HMSClients) every time would be a costly operation, and we would likely lose
everything that we win by using a pool.
Basically the expectation is that we have a global catalog cache and a thin
Catalog wrapper using it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
