NeQuissimus commented on code in PR #5166:
URL: https://github.com/apache/iceberg/pull/5166#discussion_r911090043
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -547,6 +547,11 @@ protected Map<String, String> properties() {
return catalogProperties == null ? ImmutableMap.of() : catalogProperties;
}
+ public void close() {
+ fileIO.close();
+ clients.close();
Review Comment:
This is why I did not link this method into existing code paths and left it
completely optional.
For users of `HiveCatalog` there needs to be a way to close the resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
