NeQuissimus commented on code in PR #5166:
URL: https://github.com/apache/iceberg/pull/5166#discussion_r911112520
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -547,6 +547,11 @@ protected Map<String, String> properties() {
return catalogProperties == null ? ImmutableMap.of() : catalogProperties;
}
+ public void close() {
+ fileIO.close();
+ clients.close();
Review Comment:
So when I have a `HiveCatalog`, I can just throw it away? This seems strange
with resources inside it that seemingly need to have `close`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
