pvary commented on code in PR #5166:
URL: https://github.com/apache/iceberg/pull/5166#discussion_r911096792
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -547,6 +547,11 @@ protected Map<String, String> properties() {
return catalogProperties == null ? ImmutableMap.of() : catalogProperties;
}
+ public void close() {
+ fileIO.close();
+ clients.close();
Review Comment:
Based on the timeout the pool should be closed by inactivity:
See:
```
clientPoolCache =
Caffeine.newBuilder().expireAfterAccess(evictionInterval, TimeUnit.MILLISECONDS)
.removalListener((key, value, cause) -> ((HiveClientPool)
value).close())
.build();
```
I am afraid that having a close method will communicate the users that this
should be called every time, which will cause performance issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
