kbendick commented on PR #5190:
URL: https://github.com/apache/iceberg/pull/5190#issuecomment-1173283625

   The 1 remaining error prone warning in API module requires a bit more 
caution when / if we address it as quite a lot of code uses `ExceptionUtil`.
   
   ```
   iceberg/api/src/main/java/org/apache/iceberg/util/ExceptionUtil.java:124: 
warning: [Finally] If you return or throw from a finally, then values returned 
or thrown from the try-catch block will be ignored. Consider using 
try-with-resources instead.
               throw new RuntimeException("Unknown exception in finally block", 
failure);
               ^
       (see https://errorprone.info/bugpattern/Finally)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to