kbendick commented on PR #5190:
URL: https://github.com/apache/iceberg/pull/5190#issuecomment-1175434502
> Looks like this can be closed as these were fixed in: #5200
>
> Thanks all!
My mistake. These two were not fixed in #5200. I'll switch from `failure` to
`e` as mentioned by @nastra.
In master, I still see these warnings:
```
> Task :iceberg-api:compileJava
/Users/kylebendickson/repos/iceberg/api/src/main/java/org/apache/iceberg/util/ExceptionUtil.java:124:
warning: [Finally] If you return or throw from a finally, then values returned
or thrown from the try-catch block will be ignored. Consider using
try-with-resources instead.
throw new RuntimeException("Unknown exception in finally block",
failure);
^
(see https://errorprone.info/bugpattern/Finally)
/Users/kylebendickson/repos/iceberg/api/src/main/java/org/apache/iceberg/io/FileIO.java:65:
warning: [MissingSummary] A summary line is required on public/protected
Javadocs.
* @return the property map used to configure this FileIO
^
(see
https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
/Users/kylebendickson/repos/iceberg/api/src/main/java/org/apache/iceberg/io/CredentialSupplier.java:31:
warning: [MissingSummary] A summary fragment is required; consider using the
value of the @return block as a summary fragment instead.
* @return the credential string
^
(see
https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
Did you mean '*Returns the credential string.'?
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
3 warnings
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
