kbendick commented on PR #5190: URL: https://github.com/apache/iceberg/pull/5190#issuecomment-1175456591
> If there are multiple exceptions, then I think we should add the one that isn't thrown as a suppressed exception on the one that we do throw. This seems to happen already on line 118, but we're not rethrowing it from within the finally block (which is what the warning message is mentioning if I'm not mistaken): https://github.com/apache/iceberg/blob/d563d6db0a56199306c82187027fb76e2bf41be2/api/src/main/java/org/apache/iceberg/util/ExceptionUtil.java#L118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
