kbendick commented on PR #5190: URL: https://github.com/apache/iceberg/pull/5190#issuecomment-1175443108
Switching from throwing `e` instead of `finally` still gives the exception message. But I agree that at line 124, we know that `failure` is `null` so we should probably throw `e` instead as it's likely non-null. And we're trying to throw `e` in the 4 lines above 127 (as we're not suppressing there): https://github.com/apache/iceberg/blob/d563d6db0a56199306c82187027fb76e2bf41be2/api/src/main/java/org/apache/iceberg/util/ExceptionUtil.java#L117-L124 So it looks like we need to change to throwing `e` at line 127 (where we've tried throwing `e` as several different types in the preceding lines) and then also add the suppression. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
