rdblue commented on code in PR #5407:
URL: https://github.com/apache/iceberg/pull/5407#discussion_r939734058
##########
core/src/main/java/org/apache/iceberg/rest/ResourcePaths.java:
##########
@@ -74,4 +74,8 @@ public String table(TableIdentifier ident) {
public String rename() {
return SLASH.join("v1", prefix, "tables", "rename");
}
+
+ public String scanReport() {
+ return SLASH.join("v1", prefix, "metrics", "scan");
Review Comment:
Why not make this a table-specific path, like
`v1/namespaces/ns/tables/t1/metrics`?
I think it would make more sense to have a table-specific path. Similar to
how we're adding `prefix` to the path already, I think it is better for the
client to keep track of the table and post metrics to the correct table,
instead of using a generic endpoint and making the service decide which table
the metrics are for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
