rdblue commented on code in PR #5407:
URL: https://github.com/apache/iceberg/pull/5407#discussion_r950578521
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -284,14 +286,30 @@ public Table loadTable(SessionContext context,
TableIdentifier identifier) {
tableFileIO(response.config()),
response.tableMetadata());
- BaseTable table = new BaseTable(ops, fullTableName(loadedIdent),
this.scanReporter);
+ final TableIdentifier tableIdentifier = loadedIdent;
Review Comment:
In Iceberg, we avoid using `final` for local variables because Java is now
good at detecting this automatically and it doesn't make much of a difference
for performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
