rdblue commented on code in PR #5407:
URL: https://github.com/apache/iceberg/pull/5407#discussion_r967896039
##########
core/src/main/java/org/apache/iceberg/rest/ResourcePaths.java:
##########
@@ -74,4 +74,16 @@ public String table(TableIdentifier ident) {
public String rename() {
return SLASH.join("v1", prefix, "tables", "rename");
}
+
+ public String scanReport(TableIdentifier identifier) {
+ return SLASH.join(
+ "v1",
+ prefix,
+ "namespaces",
+ RESTUtil.encodeNamespace(identifier.namespace()),
+ "tables",
+ RESTUtil.encodeString(identifier.name()),
+ "metrics",
+ "scan");
Review Comment:
I thought about this for a while and I think we should go with the generic
metrics endpoint rather than specific endpoints for scan, commit, etc. That
keeps the REST spec simpler. I also think that it fits with the potential for
future GET requests because we could provide a listing of metric reports and
filter them using query params for the `.../metrics` endpoint. We could also
return individual reports using `.../metrics/<report-id>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
