rdblue commented on code in PR #5407:
URL: https://github.com/apache/iceberg/pull/5407#discussion_r950579103
##########
core/src/main/java/org/apache/iceberg/rest/ResourcePaths.java:
##########
@@ -74,4 +74,16 @@ public String table(TableIdentifier ident) {
public String rename() {
return SLASH.join("v1", prefix, "tables", "rename");
}
+
+ public String scanReport(TableIdentifier identifier) {
+ return SLASH.join(
+ "v1",
+ prefix,
+ "namespaces",
+ RESTUtil.encodeNamespace(identifier.namespace()),
+ "tables",
+ RESTUtil.encodeString(identifier.name()),
+ "metrics",
+ "scan");
Review Comment:
Is there a reason to make multiple endpoints? Why not just post to metrics
with a type included in the serialized metrics report? That way there's only
one metrics endpoint needed and we don't need to specify this later.
We can also make the update to the REST spec generic using `anyOf`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
