JonasJ-ap commented on code in PR #5684:
URL: https://github.com/apache/iceberg/pull/5684#discussion_r962199467
##########
aws/src/main/java/org/apache/iceberg/aws/AssumeRoleAwsClientFactory.java:
##########
@@ -134,22 +125,12 @@ protected String region() {
return region;
}
- protected String s3Endpoint() {
- return s3Endpoint;
- }
-
- protected String httpClientType() {
- return httpClientType;
- }
-
- protected boolean s3UseArnRegionEnabled() {
- return s3UseArnRegionEnabled;
+ protected AwsProperties awsProperties() {
+ return awsProperties;
}
private StsClient sts() {
- return StsClient.builder()
-
.httpClientBuilder(AwsClientFactories.configureHttpClientBuilder(httpClientType))
- .build();
+ return
StsClient.builder().applyMutation(awsProperties::applyHttpClientConfiguration).build();
Review Comment:
It seems that the current format of `line 133` is favored by
`spotlessApply`. I tried to make new line for each part and triggered the
`spotlessCheck` violation.
I did some additional tests and found that we need at least two consecutive
configurations so that `spotlessCheck` allow us to make new line for each part:
```
tsClient.builder()
.applyMutation(awsProperties::applyHttpClientConfiguration)
.applyMutation(<any configuration>)
.build()
```
is allowed. But if we only have one `applyMutation`, it will be
auto-formated to
```
tsClient.builder().applyMutation(awsProperties::applyHttpClientConfiguration).build()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
