jackye1995 commented on code in PR #5684:
URL: https://github.com/apache/iceberg/pull/5684#discussion_r962114239
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -121,64 +107,38 @@ public S3Client s3() {
@Override
public GlueClient glue() {
return GlueClient.builder()
- .httpClientBuilder(configureHttpClientBuilder(httpClientType))
- .applyMutation(builder -> configureEndpoint(builder, glueEndpoint))
+ .applyMutation(awsProperties::applyHttpClientConfiguration)
+ .applyMutation(builder -> configureEndpoint(builder,
awsProperties.glueEndpoint()))
.build();
}
@Override
public KmsClient kms() {
- return KmsClient.builder()
- .httpClientBuilder(configureHttpClientBuilder(httpClientType))
- .build();
+ return
KmsClient.builder().applyMutation(awsProperties::applyHttpClientConfiguration).build();
Review Comment:
nit: newline within builder chain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
