rdblue commented on code in PR #5407:
URL: https://github.com/apache/iceberg/pull/5407#discussion_r967897246
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1016,6 +1040,110 @@ components:
items:
type: integer
+ Expression:
+ oneOf:
+ - $ref: '#/components/schemas/AndOrExpression'
+ - $ref: '#/components/schemas/NotExpression'
+ - $ref: '#/components/schemas/SetExpression'
+ - $ref: '#/components/schemas/LiteralExpression'
+
+ ExpressionType:
+ type: string
+ example:
+ - "eq"
+ - "and"
+ - "or"
+ - "not"
+ - "in"
+ - "not-in"
+ - "lt"
+ - "lt-eq"
+ - "gt"
+ - "gt-eq"
Review Comment:
For updates, we use a single enum, rather than restricting values in each
type:
```
properties:
action:
type: string
enum:
- upgrade-format-version
- add-schema
- set-current-schema
- add-spec
- set-default-spec
- add-sort-order
- set-default-sort-order
- add-snapshot
- set-snapshot-ref
- remove-snapshots
- remove-snapshot-ref
- set-location
- set-properties
- remove-properties
```
It seems like we should be consistent with the approach for type identifiers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
