jackye1995 commented on code in PR #5787:
URL: https://github.com/apache/iceberg/pull/5787#discussion_r977775281
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -352,6 +354,33 @@ public class AwsProperties implements Serializable {
public static final String HTTP_CLIENT_TYPE_DEFAULT =
HTTP_CLIENT_TYPE_URLCONNECTION;
+ /**
+ * Used to configure the connection timeout in milliseconds for {@link
+ * software.amazon.awssdk.http.apache.ApacheHttpClient.Builder}. This flag
only works when {@link
+ * #HTTP_CLIENT_TYPE} is set to {@link #HTTP_CLIENT_TYPE_APACHE}
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/apache/ApacheHttpClient.Builder.html
+ */
+ public static final String APACHE_HTTP_CLIENT_CONNECTION_TIMEOUT_MS =
+ "apache.connection-timeout-ms";
+
+ public static final long APACHE_HTTP_CLIENT_CONNECTION_TIMEOUT_MS_DEFAULT =
Review Comment:
we should not set a default here, when not set we should not set the value
in builder so it takes the default there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
