jackye1995 commented on code in PR #5787:
URL: https://github.com/apache/iceberg/pull/5787#discussion_r979080448
##########
core/src/main/java/org/apache/iceberg/util/PropertyUtil.java:
##########
@@ -66,6 +66,15 @@ public static long propertyAsLong(
return defaultValue;
}
+ public static Long propertyAsLong(
Review Comment:
looks like the only use case is when the default is null? I think we can
name this something as `propertyAsNullableLong` and remove the default value
parameter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
